https://bugzilla.redhat.com/show_bug.cgi?id=1151747 pjp <pj.pandit@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED --- Comment #3 from pjp <pj.pandit@xxxxxxxxxxx> --- Hello Robert, Thank you so much for this review, I appreciate it. (In reply to Robert Mayr from comment #2) > [!]: Package consistently uses macros (instead of hard-coded directory names). > You use %global to define the same name as %name, why? Right, it should have been onionshare_gui; It's fixed now. > Generic: > [!]: Sources can be downloaded from URI in Source: tag > Note: Could not download Source0: > https://github.com/micahflee/onionshare/archive/onionshare-0.6.tar.gz > See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags > > Please fix this, github uses redirects, so your source should be known as > v0.6.tar.gz. Add at least a comment or refer to the other solution in the > link above. > > onionshare.src: W: invalid-url Source0: > https://github.com/micahflee/onionshare/archive/onionshare-0.6.tar.gz HTTP > Error 404: Not Found > 2 packages and 0 specfiles checked; 0 errors, 5 warnings. > > See comment above to fix this. Yep, fixed now. Please see: -> https://pjp.fedorapeople.org/onionshare.spec -> https://pjp.fedorapeople.org/onionshare-0.6-2.fc19.src.rpm -> http://koji.fedoraproject.org/koji/taskinfo?taskID=7834260 Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review