[Bug 1117025] Review Request: rubygem-joiner - Builds ActiveRecord joins from association paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1117025



--- Comment #3 from František Dvořák <valtri@xxxxxxxxxx> ---
(In reply to Ken Dreyer from comment #2)
> 
> > 5) (question) there is not used "require 'active_record'" anywere in joiner
> > sources, but I guess it's OK (developers using joiner will require rails or
> > activerecord anyway?)
> 
> Interesting, I guess upstream thinks it's fine to just require it in the
> gemspec and not in the actual library.
> 
> In the RPM case, since we Require: rubygem(activerecord) I think it's ok,
> but your point is valid that upstream probably needs to think about the
> non-Bundler case.
> 
> When you were testing in your chroot, did rubygem-activerecord get installed
> there? Or did you install the package with --nodeps? It's weird that it
> would break like that for you, since the dependency is in the RPM.

Yes, rubygem-activerecord were installed (with the rubygem-rails).

The command:
  ruby -e "require 'active_record'; require 'joiner'"
works fine.

It is not problem with packaging, and using ActiveRecord already is probably
expected.

Anyway, package can be approved. I'll create the final report yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]