https://bugzilla.redhat.com/show_bug.cgi?id=1151464 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@xxxxxxxx --- Comment #1 from Raphael Groner <projects.rg@xxxxxxxx> --- Only some hints as a manually informal review: > %install > rm -rf %{buildroot} Removal of %{buildroot} is no longer necessary, except for EPEL 5. - Do you plan to provide an EPEL package? > # Install additional docs > install -p -m 644 COPYING.txt LIESMICH.txt README.txt doc/authors.txt \ > %{buildroot}%{_pkgdocdir} This is not needed and should be handled in %files section with the %doc tag: %files %doc COPYING.txt LIESMICH.txt README.txt doc/authors.txt > convert -gravity south \ … I don't understand. Why do you manipulate the icons so much? You should put a comment in the spec file why that is necessary. Ask upstream why the icons are not provided in the tarball, may there be any legal reasons? Be careful with additional or legal questionable content cause Fedora does only allow free stuff: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Content_Licenses There are two patches available at upstream, committed after the 1.1.0 release: fullscreen fix and SDL2 usage. Maybe consider to include them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review