[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1109717

Dmitry Tantsur <divius.inside@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |divius.inside@xxxxxxxxx



--- Comment #7 from Dmitry Tantsur <divius.inside@xxxxxxxxx> ---
Hi!

1. BuildRequires:  python
should be 
BuildRequires:  python2-devel

2. find Evtx -name '*.py' | xargs sed -i '/\/usr\/bin\/python/d'
I think it would be better to check for shebang only, something like:
| xargs sed -i ''/^#!.*\/python/d'

3. Why not use summary and description from package's setup.py?
https://github.com/williballenthin/python-evtx/blob/master/setup.py
Also I think in "Programming documentation for %{name}" using full summary of
the base package would be more helpful for a user.


Newer build for reference:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7811652

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]