https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Dmitry Tantsur <divius.inside@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |divius.inside@xxxxxxxxx --- Comment #1 from Dmitry Tantsur <divius.inside@xxxxxxxxx> --- Hi! Some comments to this package: 1. Inconsistent python2 and python3 packages naming (note case): python-flask-rstpages-0.3-1.fc20.noarch.rpm python3-Flask-RSTPages-0.3-1.fc20.noarch.rpm 2. sphinx-build-3.3 docs html I suggest using just sphinx-build-3 (it's also present). There's no point in assuming specific version of Python 3. E.g. in F21 your package fails to build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7811395 3. You should BuildRequire python[3]-flask, otherwise Sphinx fails with ImportError on building docs. 4. You have this line (likely due to following Python packaging guide): find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|' but the guide also states symmetric: find -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python2}|' after Python 3 part. 5. %doc html docs/_themes/LICENSE LICENSE Here one LICENSE file is overwriting another, so only the last is actually included. Smaller things: 1. Somewhere your spec is using %if %{?with_python3} somewhere %if 0%{?with_python3} I guess it should be just %if 0%{?with_python3} everywhere, but at least it should be consistent. 2. Just a suggestion: won't it be good to Provide: Flask-RSTPages so that people can easily find it? F20 build for reference: http://koji.fedoraproject.org/koji/taskinfo?taskID=7811450 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review