[Bug 1141711] Review Request: fusionforge - collaborative development tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1141711



--- Comment #12 from Lubomir Rintel <lkundrak@xxxxx> ---
(In reply to Thorsten Glaser from comment #10)
> (In reply to Lubomir Rintel from comment #9)
> 
> > Some tips:
> > * Do _NOT_ assume database is running
> > * Do not fail under any circumstances
> 
> These two *directly* contradict each other.
> 
> Either a working PostgreSQL instance is available for installation,
> or the installation MUST fail.

They don't if you don't attempt to connect to the database upon package
installation in the first place.

The %post is possibly the most wrong place you can attempt to do that kind of
stuff -- you can't be sure about anything running, you can't do anything about
that and you can't abort the package installation. Returning a non-zero status
means you tried to do that -- a packaging bug.

If a package needs a running system to set it up it needs to be done _after_
the package is installed. Adding a README with instructions for the operator is
one estabilished pracitce for that. Doing that from withing a service during
system startup is another one (and systemd makes it rather convenient too).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]