[Bug 1006197] Review Request: stockfish - Powerful open source chess engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1006197



--- Comment #10 from Raphael Groner <projects.rg@xxxxxxxx> ---
(In reply to Dhiru Kholia from comment #5)
…
> Spec URL:
> https://bitbucket.org/dhiru/packages/raw/master/stockfish/stockfish.spec
> SRPM URL:
> https://bitbucket.org/dhiru/packages/raw/master/stockfish/stockfish-4-2.fc19.
> src.rpm

% rpmlint stockfish.spec stockfish-4-2.fc22.x86_64.rpm
stockfish-4-2.fc19.src.rpm 
stockfish.spec: W: invalid-url Source1: stockfish-231-book.zip
Should be OK, since you're providing the file in your SRPM.

stockfish.x86_64: W: spelling-error %description -l en_US eboard -> board,
aboard, e board
Maybe easily fixable.

stockfish.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/stockfish/Copying.txt
You may use the tool dos2unix to fix this.

stockfish.x86_64: W: no-manual-page-for-binary stockfish
Not needed if upstream does not provide.

stockfish.src: W: spelling-error %description -l en_US eboard -> board, aboard,
e board
Ignored. False positive.


Remove ExclusiveArch cause those are now the default primary ones in rawhide.

You should use macros where possible:
- sed -i "/Book File/s:book.bin:/usr/share/stockfish/Book.bin:"
src/ucioption.cpp
+ sed -i "/Book File/s:book.bin:%{_datadir}/%{name}/Book.bin:"
src/ucioption.cpp

The folder /var/games is marked as deprecated in FHS. What is
/var/games/stockfish/polyglot.ini about, configuration? If so, consider to move
the file into folder /etc/stockfish/ instead and patch the source to find it
there.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]