https://bugzilla.redhat.com/show_bug.cgi?id=1148365 Denis Fateyev <denis@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Denis Fateyev <denis@xxxxxxxxxxx> --- The URL and Source0 are usable. Ok. The source archive is original (SHA-256: 532a09f04da80b28d420f3ff52eb4e489f10656e527a967ca131ce683b83bcc3). Ok. Summary and description are basically Ok - but I would improve them to be more informative for search, especially, the description. License verified from lib/URI/Encode.pm. GPL+ or Artistic. License is Ok. XS code not present, BuildArch is "noarch": Ok. Build log used for check (Koji rawhide build): https://kojipkgs.fedoraproject.org/work/tasks/8107/7768107/build.log Build-time dependencies are Ok. All tests passed. Ok. $ rpmlint perl-URI-Encode-0.09-1.fc22.noarch.rpm perl-URI-Encode-0.09-1.fc22.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint is Ok. $ rpm -q -lv -p perl-URI-Encode-0.09-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Oct 5 02:10 /usr/share/doc/perl-URI-Encode -rw-r--r-- 1 root root 1042 Mar 5 2013 /usr/share/doc/perl-URI-Encode/Changes -rw-r--r-- 1 root root 18407 Mar 5 2013 /usr/share/doc/perl-URI-Encode/LICENSE -rw-r--r-- 1 root root 3793 Mar 5 2013 /usr/share/doc/perl-URI-Encode/README -rw-r--r-- 1 root root 3635 Oct 5 02:10 /usr/share/man/man3/URI::Encode.3pm.gz drwxr-xr-x 2 root root 0 Oct 5 02:10 /usr/share/perl5/vendor_perl/URI -rw-r--r-- 1 root root 8158 Oct 5 02:10 /usr/share/perl5/vendor_perl/URI/Encode.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-URI-Encode-0.09-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl >= 0:5.008001 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(base) 1 perl(Carp) 1 perl(Encode) >= 2.12 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Requires are Ok. rpm -q --provides -p perl-URI-Encode-0.09-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(URI::Encode) = 0.09 1 perl-URI-Encode = 0.09-1.fc22 Provides are Ok. Package can be built successfully in Rawhide and EPEL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=7768106 https://koji.fedoraproject.org/koji/taskinfo?taskID=7768288 Build is Ok. Package is in line with Fedora and Perl packaging guidelines. Review result: package is APPROVED. The recommendation is only to improve package's summary and description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review