[Bug 1021721] Review Request: python-salttesting - Testing library for SaltStack projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1021721



--- Comment #21 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Sorry for the delay.

warning: bogus date in %changelog: Mon Oct 23 2013 Erik Johnson
<erik@xxxxxxxxxxxxx> - 0.5.1-3
warning: bogus date in %changelog: Mon Oct 23 2013 Erik Johnson
<erik@xxxxxxxxxxxxx> - 0.5.1-2
warning: bogus date in %changelog: Mon Oct 23 2013 Erik Johnson
<erik@xxxxxxxxxxxxx> - 0.5.1-3
warning: bogus date in %changelog: Mon Oct 23 2013 Erik Johnson
<erik@xxxxxxxxxxxxx> - 0.5.1-2

Why the double install (both in %build and in %install)?
rpmlint complains about %{buildroot} being used in %build, and it seems right.

There's a problem with licensing: salttesting/pylintplugins/string_format.py is
clearly GPLv2+, but the package claims to be APACHE-2.0 as a whole. This has to
be cleared up, most likely by removing the offending file. See [1] for
discussion of compatibility.

Please add %doc LICENSE README.rst AUTHORS.rst.

[1] http://www.apache.org/licenses/GPL-compatibility.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]