https://bugzilla.redhat.com/show_bug.cgi?id=1147743 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |karlthered@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |karlthered@xxxxxxxxx Flags| |fedora-review? --- Comment #3 from Haïkel Guémar <karlthered@xxxxxxxxx> --- * You don't need to define version and release macros, they are defined for you by RPM. * Drop the Buildroot, prefix, group and vendor fields * use %{python2_sitelib} macro instead of %{_usr}/lib/python2.7/site-packages/ and %{__python2} to call the python interpreter * drop the %defattr in %files and %clean, no more required for Fedora or EL6+ * I suggest that you create a macro pypi_name to store upstream name and use it appropriately %global pypi_name nose-cov * It's a matter of style but I would put the Summary field below Name and Version. It's nicer for people reading spec files. * If your spec is based on an existing package, please mention it in the changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review