[Bug 1147149] Review Request: python-cryptography-vectors - Test vectors for the cryptography package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1147149



--- Comment #3 from Matěj Cepl <mcepl@xxxxxxxxxx> ---
(In reply to Florian "der-flo" Lehner from comment #2)
> Generic:
> [!]: Package is licensed with an open-source compatible license and meets
>      other legal requirements as defined in the legal section of Packaging
>      Guidelines.
>    ---> LICENSE is not installed

You put it to the wrong item. If you read the correct point below, you would
see "If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc." Pray, tell me, where is the LICENSE file hidden
in the original tarball?

    matej@wycliff: cryptography_vectors-0.5.4 (master %)$ find . -name L\*
    matej@wycliff: cryptography_vectors-0.5.4 (master %)$

> [!]: Changelog in prescribed format.
>    ---> Your %changelog-entry should look like:
>         * Sat Sep 27 2014 YOUR NAME <NAME@xxxxxx> - 0.5.4-1

Fixed 

http://mcepl.fedorapeople.org/tmp/python-cryptography-vectors-0.5.4-2.el7.src.rpm
http://mcepl.fedorapeople.org/tmp/python-cryptography-vectors.spec

> [!]: Package uses nothing in %doc for runtime.
>    ---> %doc is missing

Lovely. And what should I put to that %doc section?

> Generic:
> [!]: Spec file according to URL is the same as in SRPM.
>      Note: Spec file as given by url is not the same as in SRPM (see attached
>      diff).
>    ---> see Diff below
>      See: (this test has no URL)

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]