https://bugzilla.redhat.com/show_bug.cgi?id=1128356 --- Comment #4 from Mihkel Vain <turakas@xxxxxxxxx> --- Ok. Few comments at first: rpmlint *.rpm minipro.src: W: name-repeated-in-summary C MiniPro minipro.x86_64: W: name-repeated-in-summary C MiniPro minipro.x86_64: W: only-non-binary-in-usr-lib minipro.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/minipro minipro.x86_64: E: sourced-script-with-shebang /etc/bash_completion.d/minipro /bin/bash minipro.x86_64: W: no-manual-page-for-binary minipro-query-db minipro.x86_64: W: no-manual-page-for-binary miniprohex minipro-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.c minipro-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.h 3 packages and 0 specfiles checked; 3 errors, 6 warnings. -------------------------------------------- minipro.src: W: name-repeated-in-summary C MiniPro minipro.x86_64: W: name-repeated-in-summary C MiniPro To me Summary looks fine. I think we can ignore those. minipro.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/minipro minipro.x86_64: E: sourced-script-with-shebang /etc/bash_completion.d/minipro /bin/bash I think you should remove the shebang minipro.x86_64: W: no-manual-page-for-binary minipro-query-db minipro.x86_64: W: no-manual-page-for-binary miniprohex minipro-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.c minipro-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.h Manual pages are a SHOULD according to this https://fedoraproject.org/wiki/Packaging:ReviewGuidelines But not a blocker. Also you should notify upstream about fsf address. So. If you remove shebang I think we are good to go. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review