[Bug 1054941] Review Request: esteidfirefoxplugin - EstEID browser plugin for digital signing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1054941



--- Comment #5 from Lubomir Rintel <lkundrak@xxxxx> ---
1.) Compiler flags still not good

> %configure || :

This does not work; Makefile uses C_FLAGS variable. Even if it worked, it's
ugly and relies implementation details which can change. This might be a better
idea:

make plugin %{?_smp_mflags} C_FLAGS='%{optflags} -std=gnu99'

2.) Unnecessary make install

> make install DESTDIR=%{buildroot}

Just drop this. Apart from that it installs nothing, it is broken and does an
unnecessary rebuild, which is unacceptable at %install phase.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]