https://bugzilla.redhat.com/show_bug.cgi?id=1139043 David Dick <ddick@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from David Dick <ddick@xxxxxxxx> --- (In reply to Denis Fateyev from comment #2) > (In reply to David Dick from comment #1) > > > BR: perl(Test::Pod) > > BR: perl(Test::Pod::Coverage) > > BR: perl(Test::Perl::Critic) > > > > can be removed as they are not included in the test suite that is run. They > > are only in the xt directory. > > OK. I thought whether they were needed if they were mentioned in "xt". Every module that is required during build/test/install. The "make test" does not use the "xt" directory, so it may be ignored. > > The "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line > > can be removed. It is not necessary for >= EPEL5 > > OK. I was concerned if it was working with EPEL5 too. I'm pretty sure that it is not required. If you get a build failure for EPEL5, just re-add it. Package APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review