[Bug 1144000] Review Request: autotrash - Automatically take-out the trash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1144000



--- Comment #3 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi @robyduck.
Some comments:
- Use python2-devel instead python-devel, also is not needed conditioning the
versioning http://fedoraproject.org/wiki/Packaging:Python#BuildRequires, at
this moment default python version in system-wide is 2.7.5, same applies to
Requires.

- The use of %{__python} is deprecated,  use instead  %{__python2}
http://fedoraproject.org/wiki/Packaging:Python#Macros.

- Each time that you make changes in your spec bump the release to reflect the
changes at the time

- The spec differ to the SRPM uploaded

Diff spec file in url and in SRPM
---------------------------------
--- /home/echevemaster/test-packages/1144000-autotrash/srpm/autotrash.spec   
2014-09-28 10:44:57.530000000 -0430
+++
/home/echevemaster/test-packages/1144000-autotrash/srpm-unpacked/autotrash.spec
   2014-09-27 16:49:03.000000000 -0430
@@ -21,4 +21,5 @@
 %{__python} setup.py build

+
 %install
 %{__python} setup.py install --skip-build --root %{buildroot}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]