https://bugzilla.redhat.com/show_bug.cgi?id=1144000 Pranav Kant <pranav913@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pranav913@xxxxxxxxx --- Comment #1 from Pranav Kant <pranav913@xxxxxxxxx> --- This is an unofficial review only. ------------------ [x] Passed [-] Not applicable [!] Failed ------------------ [x]: rpmlint must be run on the source rpm and all binary rpms the build produces. Rpmlint on SRPM: autotrash.src: E: description-line-too-long C Autotrash is a simple Python script which will purge files from your trash based on their autotrash.src: E: description-line-too-long C age or the amount of free space left on the device. Using autotrash -d 30 will delete autotrash.src: E: description-line-too-long C files which have been in the trash for more than 30 days. It uses the FreeDesktop.org autotrash.src: E: description-line-too-long C Trash Info files included in the new GNOME system to find the correct files and the dates autotrash.src: W: invalid-url URL: http://www.logfish.net/pr/autotrash/ <urlopen error [Errno -2] Name or service not known> autotrash.src: W: invalid-url Source0: http://www.logfish.net/pr/autotrash/downloads/autotrash-0.1.5.tar.gz <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 4 errors, 2 warnings. Rpmlint on RPM: autotrash.noarch: E: description-line-too-long C Autotrash is a simple Python script which will purge files from your trash based on their autotrash.noarch: E: description-line-too-long C age or the amount of free space left on the device. Using autotrash -d 30 will delete autotrash.noarch: E: description-line-too-long C files which have been in the trash for more than 30 days. It uses the FreeDesktop.org autotrash.noarch: E: description-line-too-long C Trash Info files included in the new GNOME system to find the correct files and the dates autotrash.noarch: W: incoherent-version-in-changelog 0.1.5 ['0.1.5-1.fc21', '0.1.5-1'] autotrash.noarch: W: invalid-url URL: http://www.logfish.net/pr/autotrash/ <urlopen error [Errno -2] Name or service not known> autotrash.noarch: W: no-manual-page-for-binary autotrash 1 packages and 0 specfiles checked; 4 errors, 3 warnings. The warnings can easily be ignored but you should consider line wrap in description. Also, your change log entry is missing the release number. Follow http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs for more details and examples. [x] The package must be named according to the Package Naming Guidelines [x] The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [x] The package must meet the Packaging Guidelines [x] The package must be licensed with a Fedora approved license and meet the Licensing Guidelines [x] The License field in the package spec file must match the actual license. [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc [x] The spec file must be written in American English. [x] The spec file for the package MUST be legible. [x] The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git Source checksums ---------------- http://www.logfish.net/pr/autotrash/downloads/autotrash-0.1.5.tar.gz CHECKSUM(SHA256) : b609396fad37c37808c3c734ee5f8c04b14b3890abd671631792222e2b4787f0 CHECKSUM(SHA256) upstream package : b609396fad37c37808c3c734ee5f8c04b14b3890abd671631792222e2b4787f0 [x] The package MUST successfully compile and build into binary rpms on at least one primary architecture. [-] If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [x] All build dependencies must be listed in BuildRequires [x] The spec file MUST handle locales properly. This is done by using the %find_lang macro. [-] Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [x] Packages must NOT bundle copies of system libraries. [x] A package must own all directories that it creates. [x] A Fedora package must not list a file more than once in the spec file's %files listings. [x] Permissions on files must be set properly. Executables should be set with executable permissions [!] Each package must consistently use macros. Under %install section: You can use %{buildroot} instead of variable to consistently use macros throughout the SPEC file. [x] The package must contain code, or permissible content. [-] Large documentation files must go in a -doc subpackage. [-] If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present [-] Static libraries must be in a -static package [-] Development files must be in a -devel package. [x] Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built [-] Packages containing GUI applications must include a %{name}.desktop file. [x] Packages must not own files or directories already owned by other packages. [x] All filenames in rpm packages must be valid UTF-8 [x] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x] The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [x] The reviewer should test that the package builds in mock. [!] your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. Your package contains the man page but does not installs it. Please fix this. [X]: Latest version is packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review