https://bugzilla.redhat.com/show_bug.cgi?id=1147013 --- Comment #3 from Pranav Kant <pranav913@xxxxxxxxx> --- (In reply to Till Maas from comment #2) > Here are some intial findings: > > - Please add the URL of your upstream issue about the fsfe patch to the SPEC > together with a date stamp to make it obvious that the patch is on its way > to upstream > - Since github seems to be the main page for support etc. please use it as > URL: > https://github.com/rofl0r/proxychains-ng > - The release should start with "1" > - You mix the usage of variables with macros, e.g. both $RPM_BUILD_ROOT and > %{buildroot} is used, please use either macros or variables > - Do you know the %make_install macro? > https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_. > 25makeinstall_macro_should_not_be_used > - the %optflags are not completely honoured: > cc -shared -fPIC -Wl,--no-as-needed -ldl -lpthread > -Wl,-soname=libproxychains4.so -o libproxychains4.so src/nameinfo.o > src/version.o src/core.o src/common.o src/libproxychains.o src/shm.o > src/allocator_thread.o src/ip_type.o src/stringdump.o src/hostentdb.o > src/hash.o src/debug.o > cc src/main.o src/common.o -o proxychains4 > > Reference: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > - The package is probably also a candidate for PIE (%global _hardened_build > 1) > > - Please perform informal reviews and link to them here as described in the > wiki: > https://fedoraproject.org/wiki/ > Join_the_package_collection_maintainers#Get_Sponsored > All issues taken care in new set of SPEC, SRPM. Spec URL: http://glug.nith.ac.in/~pranavk/fedora/proxychains-ng.spec SRPM URL: http://glug.nith.ac.in/~pranavk/fedora/proxychains-ng-4.8.1-1.fc21.src.rpm Except, I am little doubtful still about if I have taken care of optflags correctly or not. Here is the link to informal review for a package I did some days ago : https://bugzilla.redhat.com/show_bug.cgi?id=909887#c4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review