Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kde-settings - Config files for kde Alias: kde-settings https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227241 ------- Additional Comments From chris.stone@xxxxxxxxx 2007-04-27 16:51 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output: W: kde-settings no-documentation okay to ignore. W: kde-settings hidden-file-or-dir /etc/skel/.kde/Autostart/.directory W: kde-settings non-conffile-in-etc /etc/skel/.kde/Autostart/.directory W: kde-settings hidden-file-or-dir /etc/skel/.kde W: kde-settings hidden-file-or-dir /etc/skel/.kde okay to ignore, bug probably should be filed against rpmlint for these. W: kde-settings no-url-tag okay to ignore. E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/clockappletrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/kcmnspluginrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/kdeglobals E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/kdesktoprc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/kdewizardrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/kickerrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/kmailrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/kminipagerappletrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/knotify.eventsrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/knotifyrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/konquerorrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/konsolerc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/korgacrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/ksmserverrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/ksplashrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/ktiprc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/kwinrc E: kde-settings file-in-usr-marked-as-conffile /usr/share/config/profilerc X explained in bug #238136, a comment should be added to the spec. W: kde-settings no-url-tag okay to ignore. W: kde-settings strange-permission xdg_env-hack.sh 0755 what is strange about that?! W: kde-settings setup-not-quiet OMG this is so easy to fix. W: kde-settings mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 3) OMG this is so easy to fix. W: kde-settings-kdm no-documentation okay to ignore. W: kde-settings-kdm dangling-relative-symlink /etc/kde/kdm/Xsetup ../../X11/xdm/Xsetup_0 W: kde-settings-kdm dangling-relative-symlink /etc/kde/kdm/Xservers ../../X11/xdm/Xservers W: kde-settings-kdm dangling-relative-symlink /etc/kde/kdm/Xwilling ../../X11/xdm/Xwilling W: kde-settings-kdm dangling-relative-symlink /etc/kde/kdm/Xaccess ../../X11/xdm/Xaccess W: kde-settings-kdm dangling-relative-symlink /etc/kde/kdm/Xresources ../../X11/xdm/Xresources These are okay since it Requires xorg-x11-xdm W: kde-settings-kdm no-url-tag okay to ignore. W: kde-settings-kdm obsolete-not-provided kde-config-kdebase Why is an obsolte not provided?? W: kde-settings-kdm dangerous-command-in-%pre mv W: kde-settings-kdm dangerous-command-in-%post cp OMG these are so easy to fix. - package named according to package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - package is licensed with open source compatible license - license matches actual license - no license in %doc because there really is no license NOTE: These are just config files, no real license associated with them. - spec written in American english - spec file legible X There are no upstream sources to match against yet no comment either - package successfully compiles and builds on FC-6 x86_64 - all dependencies listed in BR - no locales - no shared libraries in dynamic linkers path - package is not relocatable - package owns all directories it creates - directories it does not create are brought in through Requires - no duplicates in %files - file permissions are okay - contains proper %clean - macro usage consistent - contains code - no large documentation - files in %doc do not affect runtime - no header files - no static libraries - no pkgconfig files - no libraries with suffix - no need for devel subpackage - no libtool archives - not a GUI application ? package does not own files or directories owned by other packages - contains proper %install - filenames are UTF-8 I still have to verify there are no conflicts with kdebase in devel. ==== MUST FIX ==== - Add comment in spec as mentioned here: http://fedoraproject.org/wiki/Packaging/SourceURL#head-413e1c297803cfa9de0cc4c56f3ac384bff5dc9e - Add a comment in spec file mentioning bug #238136 ==== SHOULD FIX ==== - Fix rpmlint warnings: W: kde-settings setup-not-quiet W: kde-settings mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 3) W: kde-settings-kdm obsolete-not-provided kde-config-kdebase W: kde-settings-kdm dangerous-command-in-%pre mv W: kde-settings-kdm dangerous-command-in-%post cp -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review