https://bugzilla.redhat.com/show_bug.cgi?id=1141711 --- Comment #4 from Sylvain Beucler <beuc@xxxxxxxx> --- Hi Lubomir! > 0.) You seem to be packaging a version that does not exist? Yes, we revamped the whole build system for the next release, and this is why we now have a decent .spec file to propose. I submitted it for review before the release so we can spot issues ahead :) > 1.) You seem to disable the python precompilation: > > # Don't compile the .py utils from plugin-moinmoin, the pyc/pyo files are hard to properly package > %global __os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g') > > That is ordinarily not a good idea and would need a better explanation. As you saw the core of this packaging relies on 'make install' and doesn't attempt to manually relist all the files from all the different packages and plugins at every release. Among these files is are 3 MoinMoin glue/config files: /usr/share/fusionforge/plugins/moinmoin/lib/fusionforge.py /usr/share/fusionforge/plugins/moinmoin/lib/farmconfig.py /usr/share/fusionforge/plugins/moinmoin/lib/ff_groups.py Recent RPM now attempts to compile them automatically, creating new files, and then it complains they not packaged! I'd like to avoid making exception and relisting explicitely those files, which incidentally are never compiled in any other FusionForge install or packaging, hence why I disabled the Python bytecode compilation for these 3 files. I would welcome a generic approach to tackle this issue. > 2.) Your %post scriptlets seem to be somewhat fragile (some, maybe not all) Indeed the installation requires a working database connection. I'll add a README to explain how to relaunch /usr/share/fusionforge/post-install.d/xxx if there's a problem during install. > 3.) You use line breaks in weird places. You mean I sometimes use "\n\n"? This clearly separates the different sub-packages (since there is an empty line in the description, one line only is not enough for my brain). > 4.) Your section ordering is rather unusual. The plugins sections gets automatically included in the .spec file, see rpm/gen_spec.sh. It will be pretty complex and far less readable to insert all the plugins bits everywhere through the .spec file, rather than in a single bloc at the end. (also I think it suits this package better :)) > 5.) rpmlint is very unhappy. I had tried on my stable F20 but apparently quite a new tests were added. What version are you using? > fusionforge-web.noarch: W: dangling-relative-symlink /usr/share/fusionforge/www/plugins/authbuiltin ../../plugins/authbuiltin/www > fusionforge-web.noarch: W: dangling-relative-symlink /usr/share/fusionforge/www/DTD ../common/DTD The targets are in fusionforge-common, which the package depends on. I'll prepare a new srpm to fix the other warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review