[Bug 1074515] Review Request: passenger - Passenger Ruby web application server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1074515



--- Comment #22 from Jan Kaluža <jkaluza@xxxxxxxxxx> ---
(In reply to Marcela Mašláňová from comment #21)
> # Until rubygem-bluecloth is in Fedora, don't use it
> Patch201:       rubygem-passenger-4.0.18-correct_docs.patch
> When will be bluecloth in Fedora? Does it have review in progress?

Yes, there is review request (Bug 771297), but it seems to be without any
update for longer time. Note that this patch only disables regeneration of
Packaging.html, but this file is regenerated by upstream before every release
and we normally install it from passenger tarball, so there's no documentation
lost by applying this patch.

> Is it needed to duplicate isa and non-isa:
> Provides:  rubygem-passenger = %{version}-%{release}
> Provides:  rubygem-passenger%{?_isa} = %{version}-%{release}

I think it is according to guidelines for "Renaming/Replacing Existing
Packages". They say:

Explicit Provides: need to be aware of whether the package is supplying things
that can be used in an arch-independent or arch-specific fashion. For packages
that are not noarch, Provides: should be made arch-specific by applying the
%{?_isa} macro to the end of the text string in Provides (e.g. Provides:
foo%{?_isa} = 2:%{version}-%{release}).

> Is it summary updated as you promised in comments above?

Yes, it is. Previously it mentioned only Ruby, now it mentions also other
supported languages.

> The tmpfiles.d section has strange condition. If fedora>15...else. What else
> means? I guess it's because of systemd, but shouldn't be better to state
> condition also for EPEL?

I think that condition can be removed from passenger.spec. I'm going to rename
passenger only in rawhide and this is definitely not going to end up in EPEL6,
so we can keep this package without these older conditions.

I will upload fixed package soon.

> How far are you with support of passenger by nginx? Is the comment still
> valid?

I'm going to contact nginx maintainer once new passenger package will be in
rawhide. The plan is to ask for bundling exception and later bundle passenger
with nginx.srpm to compile nginx equivalent of "mod_passenger" and ship it
together with nginx.

However, this is long term plan and out of scope of this renaming review.
Passenger srpm from this review does not change anything in the current
nginx-passenger relationship.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]