[Bug 1141711] Review Request: fusionforge - collaborative development tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1141711



--- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> ---
0.) You seem to be packaging a version that does not exist?

At https://fusionforge.org/frs/?group_id=6 the latest release seems to be
5.3.2. If you're packaging a pre-release version you should have a good reason
and use the release tag properly:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning

Also, the version in %changelog is inconsistent.

1.) You seem to disable the python precompilation:

# Don't compile the .py utils from plugin-moinmoin, the pyc/pyo files are hard
to properly package
%global __os_install_post %(echo '%{__os_install_post}' | sed -e
's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g')

That is ordinarily not a good idea and would need a better explanation.

2.) Your %post scriptlets seem to be somewhat fragile (some, maybe not all)

They seem to be able to fail (e.g. assume a database running, which is
definitely not the case during image creation or anaconda installation)
therefore are not a good candidates for package scriptlets. You may want to add
a documentation file that would explain what to do after package installation
instead.

3.) You use line breaks in weird places.

Please format your whitespace consistently and don't do more than two line
breaks in sequence.

4.) Your section ordering is rather unusual.

RPM won't care but humans may be confused. The SPEC files usually are ordered
like this:

Name: package
%description
%package subpackage1
%description subpackage1
%package subpackage2
%description subpackage2
%prep
%build
%check
%post
%post subpackage1
%post subpackage2
%files
%files subpackage1
%files subpackage2
%changelog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]