https://bugzilla.redhat.com/show_bug.cgi?id=1098965 Siddharth Sharma <siddharth.kde@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adel.gadllah@xxxxxxxxx Flags| |needinfo?(adel.gadllah@gmai | |l.com) --- Comment #1 from Siddharth Sharma <siddharth.kde@xxxxxxxxx> --- This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: sed grep See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - This seems like a Java package, please install fedora-review-plugin-java to get additional checks ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. There are 2 files LICENSE.TXT and LICENSE_LLVM.TXT i see only one packaged why the LICENSE_LLVM.TXT is *NOT packaged [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 161 files have unknown license. Detailed output of licensecheck in fedora/review/1098965-capstone/licensecheck.txt [!]: License file installed when any subpackage combination is installed. capstone-python and capstone-devel doesnt have any shipped licence file with it [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/java [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build Python: [!]: Python eggs must not download any dependencies during the build process. [!]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [!]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: capstone-2.1.2-1.fc22.x86_64.rpm capstone-devel-2.1.2-1.fc22.x86_64.rpm capstone-python-2.1.2-1.fc22.x86_64.rpm capstone-java-2.1.2-1.fc22.x86_64.rpm capstone-2.1.2-1.fc22.src.rpm capstone.x86_64: W: spelling-error Summary(en_US) multi -> mulch, mufti capstone.x86_64: W: spelling-error Summary(en_US) disassembly -> disassemble, dis assembly, dis-assembly capstone.x86_64: W: summary-ended-with-dot C A lightweight multi-platform, multi-architecture disassembly framework. capstone.x86_64: W: spelling-error %description -l en_US disassembly -> disassemble, dis assembly, dis-assembly capstone.x86_64: W: spelling-error %description -l en_US disasm -> disarm, sadism capstone-devel.x86_64: W: only-non-binary-in-usr-lib capstone-devel.x86_64: W: no-documentation capstone-python.x86_64: W: no-documentation capstone-java.x86_64: W: no-documentation capstone.src: W: spelling-error Summary(en_US) multi -> mulch, mufti capstone.src: W: spelling-error Summary(en_US) disassembly -> disassemble, dis assembly, dis-assembly capstone.src: W: summary-ended-with-dot C A lightweight multi-platform, multi-architecture disassembly framework. capstone.src: W: spelling-error %description -l en_US disassembly -> disassemble, dis assembly, dis-assembly capstone.src: W: spelling-error %description -l en_US disasm -> disarm, sadism capstone.src:46: W: rpm-buildroot-usage %build DESTDIR=%{buildroot} CFLAGS="%{optflags}" LIBDIR=%{_libdir} make %{?_smp_mflags} capstone.src:49: W: rpm-buildroot-usage %build sed -i 's;%{buildroot};;' capstone.pc 5 packages and 0 specfiles checked; 0 errors, 16 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint capstone-python capstone-devel capstone-java capstone capstone-python.x86_64: W: no-documentation capstone-devel.x86_64: W: only-non-binary-in-usr-lib capstone-devel.x86_64: W: no-documentation capstone-java.x86_64: W: no-documentation capstone.x86_64: W: spelling-error Summary(en_US) multi -> mulch, mufti capstone.x86_64: W: spelling-error Summary(en_US) disassembly -> disassemble, dis assembly, dis-assembly capstone.x86_64: W: summary-ended-with-dot C A lightweight multi-platform, multi-architecture disassembly framework. capstone.x86_64: W: spelling-error %description -l en_US disassembly -> disassemble, dis assembly, dis-assembly capstone.x86_64: W: spelling-error %description -l en_US disasm -> disarm, sadism 4 packages and 0 specfiles checked; 0 errors, 9 warnings. # echo 'rpmlint-done:' Requires -------- capstone-python (rpmlib, GLIBC filtered): capstone(x86-64) python(abi) capstone-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config capstone(x86-64) libcapstone.so.2()(64bit) capstone-java (rpmlib, GLIBC filtered): capstone(x86-64) capstone (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) rtld(GNU_HASH) Provides -------- capstone-python: capstone-python capstone-python(x86-64) capstone-devel: capstone-devel capstone-devel(x86-64) pkgconfig(capstone) capstone-java: capstone-java capstone-java(x86-64) capstone: capstone capstone(x86-64) libcapstone.so.2()(64bit) Source checksums ---------------- http://www.capstone-engine.org/download/2.1.2/capstone-2.1.2.tgz : CHECKSUM(SHA256) this package : 49e41d662c5ed4dcd391ec4cfce75fb31ca4bfd245eba9e8f0cb69d6f6e8d7cc CHECKSUM(SHA256) upstream package : 49e41d662c5ed4dcd391ec4cfce75fb31ca4bfd245eba9e8f0cb69d6f6e8d7cc Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1098965 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic, Java, C/C++ Disabled plugins: fonts, SugarActivity, Ocaml, Haskell, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review