https://bugzilla.redhat.com/show_bug.cgi?id=1069556 --- Comment #6 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> --- Thanks for the review (In reply to Steve Traylen from comment #4) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Package uses either %{buildroot} or $RPM_BUILD_ROOT > Note: Using both %{buildroot} and $RPM_BUILD_ROOT > See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros Fixed > - There are some rpmlint warnings below > zeromq4-devel.x86_64: W: only-non-binary-in-usr-lib There is only the libzmq.so link inside, which is not "binary", but arch specific and definetely does not belong to /usr/share, as suggested by rpmlint. > zeromq4.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmq.so.3.1.0 > /lib64/libm.so.6 > > Maybe it's worth to investigate and at least comment on these. I cannot reproduce that here on f20, which is strange as you seem to have used f20 too... I can try to patch the build files to link to libraries as-needed, when I also see that warning on my box. (Furthermore, I think a needless R on glibc isn't that bad. It should be installed anyway...) > Comments: > ========= > As mentinoned above it's a little odd how we are packaging renaming from > zeromq3 -> 4 here > despite the fact that there is no .so bump here. > > Is another option to update the existing zeromq package to this one and add > a compat > package for runtime. > > Indeed I think the decision is yours though. I think this approach is the easiest with the less reviews needed. Once there is a new zeromqX out there, we'll need a new review request and the old ones can serve as the compat packages as needed. Yet merging back to the original zeromq package would be great to have indeed... :/ Unfortunately, I have not much time to help depending packages to port to newer zeromq's in order to kick version 2 out of Fedora. Any help is appreciated! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review