[Bug 1122941] Review Request: rubygem-font-awesome-rails - An asset gemification of the font-awesome icon font library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122941



--- Comment #3 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> ---
(In reply to Josef Stribny from comment #2)
> * Unneeded Requires / Provides for rubygem related packages
>   --> I know about that, but there is only one require and it's not on
> RubyGem, therefor it's not generated

- Well, (for sure I redownloaded and) actually your -1.fc22.src.rpm
  contains
--------------------------------
    13  Requires: ruby(release)
    14  Requires: ruby(rubygems)
    15  Requires: rubygem(railties) >= 3.2
    16  Requires: rubygem(railties) < 5.0
    27  Provides: rubygem(%{gem_name}) = %{version}
--------------------------------
  Perhaps you once created srpm, and the later you modified
  your spec file and uploaded them seperately...

  -2.fc22.src.rpm does not contain these, so it is okay.

> * ! Latest version
>   --> This is not possible if I want to reuse the files from already ready
> fontawesome-fonts package from fedora. It needs to have the same version. I
> can do updates only when fontawesome-fonts do them.

- Well, then version dependency should also be specified for
  "Requires: fontawesome-fonts".
- By the way, you can ping fontawesome-fonts to upgrade it, or
  you can offer co-maintainership for that.

Well some more comments for -2:
* rubygem-font-awesome-rails-doc.noarch: E: non-executable-script
/usr/share/gems/gems/font-awesome-rails-4.1.0.0/Rakefile 0644L /usr/bin/env
  - First of all, I wonder if shebang is needed for Rakefile...
    Please either
    * remove shebang
    * or make this have executable permission
    * or remove Rakefile at all (usually Rakefile is alike "makefile" for
      autotools based packages, and usually we don't include makefile
      or so in binary rpm - also see below)

* Shipping test suite
  - Ruby guideline requests not to package test suite in binary rpm
    (like autotools based rpm):
   
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
    See "Do not ship tests"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]