[Bug 1040517] Review Request: julia - High-level, high-performance dynamic language for technical computing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1040517



--- Comment #75 from Milan Bouchet-Valat <nalimilan@xxxxxxx> ---
(In reply to Paulo Andrade from comment #74)
> Good observation, now on my todo list whenever checking a package :)
> Try this:
[...]
> 
> I personally rarely, if ever use "%doc NAME", to avoid surprises
> with whatever rpm does behind the curtains, and also to make it
> easier to make experimental partial builds.
Thanks. Indeed the %doc directive feels pretty broken, it doesn't make any
sense to include some files twice, especially since I only asked to include a
few files, not any directory...

> BTW, the install logic is really hard to follow, I strongly suggest
> ensuring that "rpmbuild --short-circuit -bi" works. It is better for
> you (the packager), but others may benefit if looking at your package.
> I mean, use
> (cd dir; commands)
> or
> pushd dir
>    commands
> popd
> to make it easier to know what is the current directory, if
> necessary to add extra commands; usually one expects current
> directory to be the builddir.
> Avoid mv from builddir to buildroot, it just completely breaks
> --short-circuit -bi
Good idea. Looks like short-circuit works now.



New version:
Spec URL: http://nalimilan.perso.neuf.fr/transfert/julia.spec
SRPM URL: http://nalimilan.perso.neuf.fr/transfert/julia-0.3.0-7.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]