Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xerces-j2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226555 pcheung@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From pcheung@xxxxxxxxxx 2007-04-26 17:24 EST ------- (In reply to comment #3) > (In reply to comment #2) > > > > * specfile name matches %{name} > > X verify source and patches (md5sum matches upstream, know what the patches do) > > - Source0 doesn't exist > Updated link location md5sum matches > > > * skim the summary and description for typos, etc. > > * correct buildroot > > - should be: > > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > > * if %{?dist} is used, it should be in that form (note the ? and % > > locations) > > * license text included in package and marked with %doc > > * keep old changelog entries; use judgement when removing (too old? > > useless?) > > * packages meets FHS (http://www.pathname.com/fhs/) > > X rpmlint on <this package>.srpm gives no output > > W: xerces-j2 non-standard-group Text Processing/Markup/XML > > W: xerces-j2 unversioned-explicit-provides jaxp_parser_impl > > The group one is OK, please fix the unversioned-explicit-provides > Fixed > > > > X specfile is legible > > - please get rid of section tag > Done > Great! > > - URL indicates 'Xerces has moved out of the XML project and is now a project > > in its own right.' , please update with the new URL > This is the proper URL, they are just saying welcome to the new project page > they are not part of the XML project anymore. OK > > > - in this spec file, commands are usually just plain commands instead of > > macros except for %{__sed} > Fixed > Great! > > X consider using cp -p to preserve timestamps > > - please use cp -p on lines 164, 248-253 > fixed (note -a is the same as -dpR) > Ah, OK. > > X run rpmlint on the binary RPMs > > [pcheung@to-fcjpp1 pcheung]$ rpmlint > > /var/lib/mock/fedora-development-x86_64-core-pcheung/result/xerces-j2-*x86*rpm > > W: xerces-j2 non-standard-group Text Processing/Markup/XML > > W: xerces-j2 dangling-symlink /usr/share/java/jaxp_parser_impl.jar > /etc/alternatives > > W: xerces-j2 symlink-should-be-relative /usr/share/java/jaxp_parser_impl.jar > > /etc/alternatives > > - Can these symlink warnings be fixed? > No, the package needs to use the external Alternatives system, therefore the > symlinks warnings can't be removed. > OK > > > > W: xerces-j2-demo non-standard-group Development/Testing > > W: xerces-j2-demo no-documentation > > - Is there any doc for the -demo package? > No OK > > > W: xerces-j2-javadoc-apis non-standard-group Development/Documentation > > W: xerces-j2-javadoc-impl non-standard-group Development/Documentation > > W: xerces-j2-javadoc-other non-standard-group Development/Documentation > > W: xerces-j2-javadoc-xni non-standard-group Development/Documentation > > W: xerces-j2-scripts non-standard-group Text Processing/Markup/XML > > W: xerces-j2-scripts no-documentation > > - Is there any doc for the -scripts package? > No OK > > > > > SHOULD: > > * package should include license text in the package and mark it with %doc > > * package should build on i386 > > * package should build in mock > > > > Updated SRPM: > > https://mwringe.108.redhat.com/files/documents/175/351/xerces-j2-2.7.1-9jpp.1.src.rpm > Looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review