[Bug 1142445] Review Request: wireone-fonts - Wire One font by Alexei Vanyashin and Gayaneh Bagdasaryan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1142445



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package builds fine in mock in F22

+ rpmlint on generated rpms gave output
wireone-fonts.noarch: W: spelling-error %description -l en_US monoline -> mono
line, mono-line, monolingual
wireone-fonts.noarch: W: spelling-error %description -l en_US nouveau -> Noumea
wireone-fonts.noarch: W: spelling-error %description -l en_US px -> PX, ox, p
wireone-fonts.src: W: spelling-error %description -l en_US monoline -> mono
line, mono-line, monolingual
wireone-fonts.src: W: spelling-error %description -l en_US nouveau -> Noumea
wireone-fonts.src: W: spelling-error %description -l en_US px -> PX, ox, p
2 packages and 0 specfiles checked; 0 errors, 6 warnings.


+ source verified with upstream as (sha256sum)
packaged source:
1cf739c8fc17663059c2544be19cf590404e17fc9ec1778a080e13de5282e9fc
upstream source:
1cf739c8fc17663059c2544be19cf590404e17fc9ec1778a080e13de5282e9fc

+ License is OFL and included in its own text file OFL.txt

+ fontconfig file looks good

+ follows fonts packaging guidelines.

Suggestions:
1) cp command should be used with option '-p'

2) I think here you can use cyreal foundry as can be seen in output
ttname WireOne.ttf  | grep "#8"

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]