https://bugzilla.redhat.com/show_bug.cgi?id=1142407 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |i@xxxxxxxx Assignee|dev@xxxxxxxxxxx |nobody@xxxxxxxxxxxxxxxxx Flags|fedora-review? | --- Comment #3 from Christopher Meng <i@xxxxxxxx> --- 1. DO NOT use cp. Please, use install with option -m to set the perms as well, it will save your time and will avoid the weird perms by accident. Anyway, why can't this be done by make install? 2. BuildRequires: rpm-libs, rpm-devel, zlib, zlib-devel, lzma-sdk, lzma-sdk-devel, bzip2-libs, bzip2-devel Ok, please take a look at -devel packages first, Fedora packages have requires for libs if they are linked correctly. bzip2-devel: = Requires = bzip2-libs = 1.0.6-14.fc22 libbz2.so.1 zlib-devel: = Requires = libz.so.1 zlib = 1.2.8-7.fc22 And so on... So the final BR list should be: rpm-devel zlib-devel lzma-sdk-devel bzip2-devel And I hope you can put dependencies by line instead of putting them together with comma separated in one line, poor readability. 3. Is this a public library? If so you should use soname on it. 4. make %{?_smp_mflags} Please honor the %{optflags} and %{__global_ld_flags} macros. 5. %description Currently, the drpm package provides a small library allowing one to fetch various info from deltarpm packages. The long-term aim of the project is to replace the deltarpm suite completely by providing a similar, backwards-compatible deltarpm-making and -applying functionality as a part of the API, as well as in form of stand-alone utilities. We don't need any explanation about the past, just tell us the main usage: %description This project is to replace the deltarpm suite completely by providing a similar, backwards-compatible deltarpm-making and -applying functionality as a part of the API, as well as in form of stand-alone utilities. 6. @Flo I just reset the review flag because he needs a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review