https://bugzilla.redhat.com/show_bug.cgi?id=1142276 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@xxxxxxxxx --- Comment #2 from Haïkel Guémar <karlthered@xxxxxxxxx> --- @Robert: sorry, we swapped review on the list with Stephen, without noticing you take it. If you don't mind, I'll review it anyway and you could either continue it or let me finish it. Few points: * no need to clean the buildroot in %install * you should add AUTHORS NEWS and README.md in %doc * Not a blocker, but you should add Christian to add a license file :) Except that, it should be good -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review