https://bugzilla.redhat.com/show_bug.cgi?id=1121355 Jared Smith <jsmith.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |redhat-bugzilla@linuxnetz.d | |e Flags| |needinfo?(redhat-bugzilla@l | |inuxnetz.de) --- Comment #5 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- This package is looking pretty good, but isn't quite ready for approval. In particular, please review the sources for code under other licenses, and use the %global macro in your spec file instead of %define, unless there is a specific reason not to. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find MIT-LICENSE.txt in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1525760 bytes in 66 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v3 or later)", "*No copyright* MIT/X11 (BSD like)", "Unknown or generated". [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Buildroot is not present Note: Building for EPEL 5 [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Building for EPEL 5 [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define pkgname phpMyAdmin, %define mcrypt 1, %define seclib 0, %define gettext 1, %define tcpdf 1 [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: phpMyAdmin4-4.0.10.3-1.fc21.noarch.rpm phpMyAdmin4-4.0.10.3-1.fc21.src.rpm phpMyAdmin4.noarch: E: explicit-lib-dependency php-zlib phpMyAdmin4.noarch: E: non-standard-dir-perm /var/lib/phpMyAdmin/save 0750L phpMyAdmin4.noarch: E: zero-length /usr/share/phpMyAdmin/js/openlayers/theme/default/framedCloud.css phpMyAdmin4.noarch: E: non-standard-dir-perm /etc/phpMyAdmin 0750L phpMyAdmin4.noarch: E: non-standard-dir-perm /var/lib/phpMyAdmin/config 0750L phpMyAdmin4.noarch: E: non-readable /etc/phpMyAdmin/config.inc.php 0640L phpMyAdmin4.noarch: E: non-standard-dir-perm /var/lib/phpMyAdmin/upload 0750L phpMyAdmin4.src: W: spelling-error %description -l en_US phpMyAdmin -> sysadmin phpMyAdmin4.src:485: W: macro-in-%changelog %{_datadir} 2 packages and 0 specfiles checked; 7 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint phpMyAdmin4 phpMyAdmin4.noarch: E: explicit-lib-dependency php-zlib phpMyAdmin4.noarch: E: non-standard-dir-perm /var/lib/phpMyAdmin/save 0750L phpMyAdmin4.noarch: E: zero-length /usr/share/phpMyAdmin/js/openlayers/theme/default/framedCloud.css phpMyAdmin4.noarch: E: non-standard-dir-perm /etc/phpMyAdmin 0750L phpMyAdmin4.noarch: E: non-standard-dir-perm /var/lib/phpMyAdmin/config 0750L phpMyAdmin4.noarch: E: non-readable /etc/phpMyAdmin/config.inc.php 0640L phpMyAdmin4.noarch: E: non-standard-dir-perm /var/lib/phpMyAdmin/upload 0750L 1 packages and 0 specfiles checked; 7 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- phpMyAdmin4 (rpmlib, GLIBC filtered): /bin/bash /bin/sh config(phpMyAdmin4) php(language) php-bz2 php-ctype php-curl php-date php-filter php-gd php-hash php-iconv php-json php-libxml php-mbstring php-mcrypt php-mysql php-mysqli php-pcre php-php-gettext php-session php-simplexml php-spl php-tcpdf php-tcpdf-dejavu-sans-fonts php-xmlwriter php-zip php-zlib webserver Provides -------- phpMyAdmin4: config(phpMyAdmin4) phpMyAdmin4 phpmyadmin Source checksums ---------------- http://downloads.sourceforge.net/phpmyadmin/phpMyAdmin-4.0.10.3-all-languages.tar.xz : CHECKSUM(SHA256) this package : 91c9d18ec51b185875507ad37c37ffc4ec8573409f35ad204ba3ad2cb219d2bb CHECKSUM(SHA256) upstream package : 91c9d18ec51b185875507ad37c37ffc4ec8573409f35ad204ba3ad2cb219d2bb Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -n phpMyAdmin4 Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review