[Bug 1140136] Review Request: python-tooz - Coordination library for distributed systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1140136

Haïkel Guémar <karlthered@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Haïkel Guémar <karlthered@xxxxxxxxx> ---
It bundles jquery but it has a bundle exception from FPC.
According automated report below, the mock build failed due to missing
requirements on python3-retrying
but I fixed it today as a proven packager so it's due to the cache not yet
refreshed. Failing points below were manually tested by the reviewer.

Mock builds: ok
Installation: ok (for both variants)
Functioning: ok

Enabling tests is not practical since it requires memcache, zookeeper to be
present.

Since this package complies with Fedora packaging guidelines, please submit an
scm request.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)".
     8 files have unknown license. Detailed output of licensecheck in
     /home/haikel/1140136-python-tooz/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.4/site-packages,
     /usr/lib/python3.4
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-tooz , python-tooz-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.1.41 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.41
INFO: Mock Version: 1.1.41
Start: lock buildroot
INFO: installing package(s):
/home/haikel/1140136-python-tooz/results/python-tooz-0.3-1.fc22.noarch.rpm
/home/haikel/1140136-python-tooz/results/python3-tooz-0.3-1.fc22.noarch.rpm
/home/haikel/1140136-python-tooz/results/python-tooz-doc-0.3-1.fc22.noarch.rpm
ERROR: Command failed:
 # ['/usr/bin/yum', '--installroot',
'/var/lib/mock/fedora-rawhide-x86_64/root/', '--releasever', '22', 'install',
'/home/haikel/1140136-python-tooz/results/python-tooz-0.3-1.fc22.noarch.rpm',
'/home/haikel/1140136-python-tooz/results/python3-tooz-0.3-1.fc22.noarch.rpm',
'/home/haikel/1140136-python-tooz/results/python-tooz-doc-0.3-1.fc22.noarch.rpm',
'--setopt=tsflags=nocontexts']
Error: Package: python3-tooz-0.3-1.fc22.noarch
(/python3-tooz-0.3-1.fc22.noarch)
           Requires: python3-retrying
 You could try using --skip-broken to work around the problem
Error: Package: python3-tooz-0.3-1.fc22.noarch
(/python3-tooz-0.3-1.fc22.noarch)
           Requires: python3-oslo-config
 You could try running: rpm -Va --nofiles --nodigest



Rpmlint
-------
Checking: python-tooz-0.3-1.fc22.noarch.rpm
          python3-tooz-0.3-1.fc22.noarch.rpm
          python-tooz-doc-0.3-1.fc22.noarch.rpm
          python-tooz-0.3-1.fc22.src.rpm
python-tooz-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-tooz-doc/html/_static/jquery.js
4 packages and 0 specfiles checked; 0 errors, 1 warnings.




Requires
--------
python-tooz (rpmlib, GLIBC filtered):
    python(abi)
    python-babel
    python-iso8601
    python-kazoo
    python-msgpack
    python-oslo-config
    python-posix_ipc
    python-pymemcache
    python-retrying
    python-six
    python-stevedore

python-tooz-doc (rpmlib, GLIBC filtered):

python3-tooz (rpmlib, GLIBC filtered):
    python(abi)
    python3-babel
    python3-iso8601
    python3-kazoo
    python3-msgpack
    python3-oslo-config
    python3-posix_ipc
    python3-pymemcache
    python3-retrying
    python3-six
    python3-stevedore



Provides
--------
python-tooz:
    python-tooz

python-tooz-doc:
    python-tooz-doc

python3-tooz:
    python3-tooz



Source checksums
----------------
https://pypi.python.org/packages/source/t/tooz/tooz-0.3.tar.gz :
  CHECKSUM(SHA256) this package     :
22b3acd5e57f8c0ce288b0384c757645de6584b0adb4c0df0e280576a6628724
  CHECKSUM(SHA256) upstream package :
22b3acd5e57f8c0ce288b0384c757645de6584b0adb4c0df0e280576a6628724

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]