https://bugzilla.redhat.com/show_bug.cgi?id=1099166 --- Comment #24 from Martín Buenahora <martinbuenahora@xxxxxxxxxxxxxxx> --- (In reply to Rex Dieter from comment #22) > Initial comments: > > 1. MUST: fix version/release to match snapshot guidelines referenced in > comment #21 > As the upstream does occasionally releases, I prefer using that method, rather that commit versioning, as I don't totally understand how will be that way. > 2. MUST: Your %changelog is pretty empty. Please update changelog for > *every* change made to the packaging, including those here. See also: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Changelogs > (I haven't looked at the changelog guidelines yet) As I've been changing the version from release to git, I thought that I had to remove them, because rpmlint showed warnings of "inconsistent changelog". As I uploaded everything to a git repo, I can recover the changelogs, put them at the begining, and change the release to 3.2.2, and the version of the package to the number that should be. > 3. SHOULD drop extraneous "mkdir" in %install section, and use install -D > flag installing the stuff to %_bindir instead (it'll create the target > dir(s) for you). While you're at it, use -p flag too to preserve timestamps. Ok. I hope to be making the changes today. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review