https://bugzilla.redhat.com/show_bug.cgi?id=1099166 --- Comment #22 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Initial comments: 1. MUST: fix version/release to match snapshot guidelines referenced in comment #21 2. MUST: Your %changelog is pretty empty. Please update changelog for *every* change made to the packaging, including those here. See also: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs 3. SHOULD drop extraneous "mkdir" in %install section, and use install -D flag installing the stuff to %_bindir instead (it'll create the target dir(s) for you). While you're at it, use -p flag too to preserve timestamps. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review