[Bug 237883] Review Request: perl-SGML-Parser-OpenSP - Perl interface to the OpenSP SGML and XML parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SGML-Parser-OpenSP - Perl interface to the OpenSP SGML and XML parser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237883





------- Additional Comments From rc040203@xxxxxxxxxx  2007-04-26 11:14 EST -------
(In reply to comment #2)
> (In reply to comment #1)
> > Also pod-tests
> > are some sort of package integrity check, which is interesting to us.
> 
> The interesting Pod tests (those done by Test::Pod) are enabled.  I fail to see
> why we would be interested in the Pod coverage tests - if they fail, are we
> going to not ship a package because some of its Perl functions aren't
> adequately documented?
Well, it's an indication that a package is poorly implemented ...

Whether lack of docs shall result into not shipping a package needs to be judged
on a case by case basis. If the core functionalties aren't documented, I don't
see a problem in qualifying a package as "not ready for shipping".

> > I am not wanting to provide a precedence and therefor am not approving this
> > package because of this.
> 
> Quite a few packages disable various tests already,
We also have a number of packages which are failing their tests :(

> networking related,
> Module::Signature related, ones that start daemons etc.
I know, but these actually are limitations of the build-system.

I prefer seeing these packages packaged in a way such tests can be enabled by
rpmbuild options (--with ...) for builts outside of the build-system (It's at
least what I try for my perl-packages.

>  What about the other
> way - if I enable the Pod coverage tests, will you review/approve this
> package?
I probably will ;)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]