[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1138321



--- Comment #10 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) you added in the spec
cp ~/rpmbuild/SOURCES/{ReenieBeanie.ttf,OFL.txt} .

this is not going to work. Just do koji scratch build of above srpm.

You should add for any individual source files like
cp -p %{SOURCE0} %{SOURCE1} .

2) small change in summary needed as its only single font
Summary:       Renie Beanie fonts by James Grieshaber
to
Summary:       Renie Beanie font by James Grieshaber

3) you chose post-release snapshot naming. But if we look for any released
tarball on http://www.google.com/fonts/specimen/Reenie+Beanie page then its not
there. So, I will take that as no stable tarball ever released. So this is
pre-release snapshot so release tag should be
Release:       0.3.%{alphatag}%{?dist}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]