https://bugzilla.redhat.com/show_bug.cgi?id=1140403 --- Comment #4 from Christian Dersch <chrisdersch@xxxxxxxxx> --- First review done. There are some things to fix, have a look at the review below ;) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros ==> You can remove "rm -rf $RPM_BUILD_ROOT" for current Fedora releases (but required for EPEL5) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/review/1140403-dreamchess/licensecheck.txt ==> Please check this, licensecheck.txt is below, but BSD license is also mentioned in COPYRIGHT file [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/dreamchess [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dreamchess ==> Please check this [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 5 files. [!]: Package complies to the Packaging Guidelines ==> You are packaging RC1, not the final version! Please add this information in release tag https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dreamchess- data ==> Please fix this, Requires: %{name}-%{version} instead of %{name} [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _suffix -RC1, %define _engine dreamer ==> Please adjust this when fixing spec [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dreamchess-0.2.1-1.fc22.x86_64.rpm dreamchess-data-0.2.1-1.fc22.noarch.rpm dreamchess-0.2.1-1.fc22.src.rpm dreamchess.x86_64: W: spelling-error %description -l en_US xboard -> board, aboard, x board dreamchess-data.noarch: W: no-documentation dreamchess.src: W: spelling-error %description -l en_US xboard -> board, aboard, x board 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint dreamchess dreamchess-data dreamchess.x86_64: W: spelling-error %description -l en_US xboard -> board, aboard, x board dreamchess-data.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- dreamchess (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libGLU.so.1()(64bit) libSDL-1.2.so.0()(64bit) libSDL_image-1.2.so.0()(64bit) libSDL_mixer-1.2.so.0()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libmxml.so.1()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) dreamchess-data (rpmlib, GLIBC filtered): dreamchess Provides -------- dreamchess: application() application(dreamchess.desktop) dreamchess dreamchess(x86-64) dreamchess-data: dreamchess-data Source checksums ---------------- http://sf.net/projects/dreamchess/files/dreamchess/Git/dreamchess-0.2.1-RC1.tar.gz : CHECKSUM(SHA256) this package : 4956e986d4d0077f275f9f4015e39958d2a135324c9e11f8f0943a8a0d140fc9 CHECKSUM(SHA256) upstream package : 4956e986d4d0077f275f9f4015e39958d2a135324c9e11f8f0943a8a0d140fc9 https://raw.githubusercontent.com/Arch-Games/arch-games/master/packages/dreamchess/dreamchess.desktop : CHECKSUM(SHA256) this package : caaa0ea9ff7f3a5795a2b2628d1a33cb093c07f5f1f17b0418c27a78dd4efddd CHECKSUM(SHA256) upstream package : caaa0ea9ff7f3a5795a2b2628d1a33cb093c07f5f1f17b0418c27a78dd4efddd Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1140403 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ================================== licensecheck.txt BSD (3 clause) -------------- dreamchess-0.2.1-RC1/src/include/gamegui/queue.h GPL (v2 or later) ----------------- dreamchess-0.2.1-RC1/src/dreamer/pgn_parser.c dreamchess-0.2.1-RC1/src/dreamer/pgn_parser.h dreamchess-0.2.1-RC1/src/libs/san_parse.c dreamchess-0.2.1-RC1/src/pgn_parser.c dreamchess-0.2.1-RC1/src/pgn_parser.h GPL (v3 or later) ----------------- dreamchess-0.2.1-RC1/src/audio/playlist.c dreamchess-0.2.1-RC1/src/audio/playlist.h dreamchess-0.2.1-RC1/src/audio/sdlmixer.c dreamchess-0.2.1-RC1/src/board.c dreamchess-0.2.1-RC1/src/board.h dreamchess-0.2.1-RC1/src/comm.c dreamchess-0.2.1-RC1/src/comm.h dreamchess-0.2.1-RC1/src/comm_unix.c dreamchess-0.2.1-RC1/src/comm_win32.c dreamchess-0.2.1-RC1/src/credits.c dreamchess-0.2.1-RC1/src/credits.h dreamchess-0.2.1-RC1/src/debug.c dreamchess-0.2.1-RC1/src/debug.h dreamchess-0.2.1-RC1/src/dir.c dreamchess-0.2.1-RC1/src/dir.h dreamchess-0.2.1-RC1/src/dreamchess.c dreamchess-0.2.1-RC1/src/dreamchess.h dreamchess-0.2.1-RC1/src/dreamer/board.c dreamchess-0.2.1-RC1/src/dreamer/board.h dreamchess-0.2.1-RC1/src/dreamer/commands.c dreamchess-0.2.1-RC1/src/dreamer/commands.h dreamchess-0.2.1-RC1/src/dreamer/dreamer.c dreamchess-0.2.1-RC1/src/dreamer/dreamer.h dreamchess-0.2.1-RC1/src/dreamer/e_comm.c dreamchess-0.2.1-RC1/src/dreamer/e_comm.h dreamchess-0.2.1-RC1/src/dreamer/e_comm_unix.c dreamchess-0.2.1-RC1/src/dreamer/e_comm_win32.c dreamchess-0.2.1-RC1/src/dreamer/eval.c dreamchess-0.2.1-RC1/src/dreamer/eval.h dreamchess-0.2.1-RC1/src/dreamer/gen_chess_moves.c dreamchess-0.2.1-RC1/src/dreamer/hashing.c dreamchess-0.2.1-RC1/src/dreamer/hashing.h dreamchess-0.2.1-RC1/src/dreamer/history.c dreamchess-0.2.1-RC1/src/dreamer/history.h dreamchess-0.2.1-RC1/src/dreamer/main.c dreamchess-0.2.1-RC1/src/dreamer/makebook.c dreamchess-0.2.1-RC1/src/dreamer/makebook.h dreamchess-0.2.1-RC1/src/dreamer/move.c dreamchess-0.2.1-RC1/src/dreamer/move.h dreamchess-0.2.1-RC1/src/dreamer/move_data.h dreamchess-0.2.1-RC1/src/dreamer/pgn_scanner.h dreamchess-0.2.1-RC1/src/dreamer/repetition.c dreamchess-0.2.1-RC1/src/dreamer/repetition.h dreamchess-0.2.1-RC1/src/dreamer/search.c dreamchess-0.2.1-RC1/src/dreamer/search.h dreamchess-0.2.1-RC1/src/dreamer/timer.c dreamchess-0.2.1-RC1/src/dreamer/timer.h dreamchess-0.2.1-RC1/src/dreamer/transposition.c dreamchess-0.2.1-RC1/src/dreamer/transposition.h dreamchess-0.2.1-RC1/src/fen.c dreamchess-0.2.1-RC1/src/fen.h dreamchess-0.2.1-RC1/src/gamegui_dialogs/configuration.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/ingame_dialog.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/message_dialog.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/quit_dialog.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/resolution.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/styles.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/system_dialog.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/time.c dreamchess-0.2.1-RC1/src/history.c dreamchess-0.2.1-RC1/src/history.h dreamchess-0.2.1-RC1/src/include/audio.h dreamchess-0.2.1-RC1/src/include/engine.h dreamchess-0.2.1-RC1/src/include/gamegui.h dreamchess-0.2.1-RC1/src/include/gamegui/action.h dreamchess-0.2.1-RC1/src/include/gamegui/align.h dreamchess-0.2.1-RC1/src/include/gamegui/bin.h dreamchess-0.2.1-RC1/src/include/gamegui/box.h dreamchess-0.2.1-RC1/src/include/gamegui/clipping.h dreamchess-0.2.1-RC1/src/include/gamegui/container.h dreamchess-0.2.1-RC1/src/include/gamegui/dialog.h dreamchess-0.2.1-RC1/src/include/gamegui/edit.h dreamchess-0.2.1-RC1/src/include/gamegui/entry.h dreamchess-0.2.1-RC1/src/include/gamegui/frame.h dreamchess-0.2.1-RC1/src/include/gamegui/hbox.h dreamchess-0.2.1-RC1/src/include/gamegui/image.h dreamchess-0.2.1-RC1/src/include/gamegui/label.h dreamchess-0.2.1-RC1/src/include/gamegui/option.h dreamchess-0.2.1-RC1/src/include/gamegui/scrollbarv.h dreamchess-0.2.1-RC1/src/include/gamegui/select.h dreamchess-0.2.1-RC1/src/include/gamegui/seperatorh.h dreamchess-0.2.1-RC1/src/include/gamegui/seperatorv.h dreamchess-0.2.1-RC1/src/include/gamegui/signal.h dreamchess-0.2.1-RC1/src/include/gamegui/system.h dreamchess-0.2.1-RC1/src/include/gamegui/vbox.h dreamchess-0.2.1-RC1/src/include/gamegui/viewport.h dreamchess-0.2.1-RC1/src/include/gamegui/widget.h dreamchess-0.2.1-RC1/src/include/gamegui_dialogs.h dreamchess-0.2.1-RC1/src/include/main_sdlthd.h dreamchess-0.2.1-RC1/src/include/options.h dreamchess-0.2.1-RC1/src/include/pipe_mem.h dreamchess-0.2.1-RC1/src/include/pipe_unix.h dreamchess-0.2.1-RC1/src/include/pipe_win32.h dreamchess-0.2.1-RC1/src/include/san.h dreamchess-0.2.1-RC1/src/include/system_config.h dreamchess-0.2.1-RC1/src/include/theme.h dreamchess-0.2.1-RC1/src/libs/gamegui/action.c dreamchess-0.2.1-RC1/src/libs/gamegui/align.c dreamchess-0.2.1-RC1/src/libs/gamegui/bin.c dreamchess-0.2.1-RC1/src/libs/gamegui/box.c dreamchess-0.2.1-RC1/src/libs/gamegui/clipping.c dreamchess-0.2.1-RC1/src/libs/gamegui/container.c dreamchess-0.2.1-RC1/src/libs/gamegui/dialog.c dreamchess-0.2.1-RC1/src/libs/gamegui/edit.c dreamchess-0.2.1-RC1/src/libs/gamegui/entry.c dreamchess-0.2.1-RC1/src/libs/gamegui/frame.c dreamchess-0.2.1-RC1/src/libs/gamegui/hbox.c dreamchess-0.2.1-RC1/src/libs/gamegui/image.c dreamchess-0.2.1-RC1/src/libs/gamegui/label.c dreamchess-0.2.1-RC1/src/libs/gamegui/option.c dreamchess-0.2.1-RC1/src/libs/gamegui/scrollbarv.c dreamchess-0.2.1-RC1/src/libs/gamegui/select.c dreamchess-0.2.1-RC1/src/libs/gamegui/seperatorh.c dreamchess-0.2.1-RC1/src/libs/gamegui/seperatorv.c dreamchess-0.2.1-RC1/src/libs/gamegui/signal.c dreamchess-0.2.1-RC1/src/libs/gamegui/system.c dreamchess-0.2.1-RC1/src/libs/gamegui/vbox.c dreamchess-0.2.1-RC1/src/libs/gamegui/viewport.c dreamchess-0.2.1-RC1/src/libs/gamegui/widget.c dreamchess-0.2.1-RC1/src/libs/msgbuf.c dreamchess-0.2.1-RC1/src/libs/msgbuf.h dreamchess-0.2.1-RC1/src/libs/pipe_beos.c dreamchess-0.2.1-RC1/src/libs/pipe_unix.c dreamchess-0.2.1-RC1/src/libs/pipe_win32.c dreamchess-0.2.1-RC1/src/main.c dreamchess-0.2.1-RC1/src/options.c dreamchess-0.2.1-RC1/src/pgn_scanner.h dreamchess-0.2.1-RC1/src/system_config.c dreamchess-0.2.1-RC1/src/theme.c dreamchess-0.2.1-RC1/src/ui.c dreamchess-0.2.1-RC1/src/ui.h dreamchess-0.2.1-RC1/src/ui_sdlgl/colours.c dreamchess-0.2.1-RC1/src/ui_sdlgl/credits.c dreamchess-0.2.1-RC1/src/ui_sdlgl/draw_scene.c dreamchess-0.2.1-RC1/src/ui_sdlgl/draw_shape.c dreamchess-0.2.1-RC1/src/ui_sdlgl/gamegui_driver.c dreamchess-0.2.1-RC1/src/ui_sdlgl/get_move.c dreamchess-0.2.1-RC1/src/ui_sdlgl/ingame_ui.c dreamchess-0.2.1-RC1/src/ui_sdlgl/load_data.c dreamchess-0.2.1-RC1/src/ui_sdlgl/promote_dialog.c dreamchess-0.2.1-RC1/src/ui_sdlgl/saveload_dialog.c dreamchess-0.2.1-RC1/src/ui_sdlgl/system.c dreamchess-0.2.1-RC1/src/ui_sdlgl/text.c dreamchess-0.2.1-RC1/src/ui_sdlgl/texture.c dreamchess-0.2.1-RC1/src/ui_sdlgl/theme.c dreamchess-0.2.1-RC1/src/ui_sdlgl/title_dialog.c dreamchess-0.2.1-RC1/src/ui_sdlgl/transitions.c dreamchess-0.2.1-RC1/src/ui_sdlgl/ui_sdlgl.c dreamchess-0.2.1-RC1/src/ui_sdlgl/ui_sdlgl.h dreamchess-0.2.1-RC1/src/ui_sdlgl/ui_sdlgl_3d.c dreamchess-0.2.1-RC1/src/ui_sdlgl/ui_sdlgl_3d.h dreamchess-0.2.1-RC1/src/ui_sdlgl/victory_dialog.c dreamchess-0.2.1-RC1/src/ui_sdlgl/vkeyboard.c dreamchess-0.2.1-RC1/src/ui_sdlgl/xmlsavefile.c Unknown or generated -------------------- dreamchess-0.2.1-RC1/src/dreamer/pgn_scanner.c dreamchess-0.2.1-RC1/src/include/git_rev.h dreamchess-0.2.1-RC1/src/macosx/makeapp.pl dreamchess-0.2.1-RC1/src/pgn_scanner.c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review