Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: remind - Sophisticated calendar and alarm program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235802 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-26 01:42 EST ------- I will review this formally ----------------------------------------------------- * MUST FIX or SHOULD FIX. If you have a reason you don't want to, please explain why. ? Question or suggestion. This is not a blocker ----------------------------------------------------- For 03.00.24-1.1: * Release number - Release number should be integer, except for some exceptions. * Timestamps - man pages are installed without any modification during build stage and keeping timestamps on these files is recommended. For this package, it can be done by ------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -c -p" ------------------------------------------------------ * %check - There seems to be a test program. ------------------------------------------------------ [tasaka1@localhost remind-03.00.24]$ pwd /home/tasaka1/rpmbuild/BUILD/remind-03.00.24 [tasaka1@localhost remind-03.00.24]$ cd src [tasaka1@localhost src]$ make test sh ../tests/test-rem Remind: Acceptance test PASSED ------------------------------------------------------ Consider to add %check section. * Documentation - IMO it is better to add the followings as documentation ------------------------------------------------------ ACKNOWLEDGEMENTS ------------------------------------------------------ - The following documents are not needed ------------------------------------------------------ README - Unlike normal software, this README explains how to install by themselves and this is not needed for rpm users. ------------------------------------------------------ ? WWW scripts - docs/README.UNIX says: ------------------------------------------------------ The subdirectory "www" contains scripts for making a nice calendar web server. See the files README and Makefile in that directory. ------------------------------------------------------ IMO it is better to install the files under www by proper procedure. ? Icons - For desktop file, it is recommended to install a icon which represents this packge together. Please contact upstream to install some icon. Well, this package is almost okay. Then: ------------------------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora Extras package review requests which are waiting for someone to review can be checked on: https://bugzilla.redhat.com/bugzilla/buglist.cgi?cmdtype=runnamed&namedcmd=mtasaka-review-noone NOTE: FE-NEW blockers are now not complete. Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review