[Bug 1136972] Review Request: paflib - POWER Architecture facilities library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1136972



--- Comment #11 from Dan Horák <dan@xxxxxxxx> ---
few more things:
- %{_includedir}/paf directory is unowned, add "%dir %{_includedir}/paf" to
%files for devel subpackage
- why not make the version set to 0.1.3? you can the use "setup -q -n
%{name}-0.1"
- use fully specified dependency for devel subpackage
(http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package)
- you might use %{power64} instead of ppc64 ppc64le, it would cover also pp64p7
subarch
- use wildcards for man pages: %{_mandir}/man3/libpaf-dsc.3.gz =>
%{_mandir}/man3/libpaf-dsc.3* (it covers situations when the compression
algorithm will change)
- Summary should be shortened, to eg. "Library for accessing Power Architecture
Facilities"
- does upstream provide any API or ABI stability for the library?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]