Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: HippoDraw - Interactive and Python scriptable data analysis application https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-26 00:11 EST ------- For 1.20.0-1: * Release number dependency - Usually, the dependency for "main" package should be release number specific. Check the dependency of -devel-docs against -devel subpackage. * Desktop file - Icon name differs. * Again #define macro - My recognition is that Hans want to say that if #define macro is needed (this time in hippoconfig.h), the name to be defined should not generic. ----------------------------------------------- Last when the number of #ifdef HAVE_XXX lines in public header files is reduced the a minimum, change them to #ifdef HIPPODRAW_WITH_XXX, and create a hippodraw_conf.h with only the #ifdef HIPPODRAW_WITH_XXX defines in it, and include that from the header files who need the #ifdef HIPPODRAW_WITH_XXX defines. ------------------------------------------------ So, HAVE_CFITSIO should be renamed to WITH_HIPPODRAW_CFITSIO, for example. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review