[Bug 1136972] Review Request: paflib - POWER Architecture facilities library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1136972



--- Comment #9 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
* Please remove this line in %install:
rm -rf $RPM_BUILD_ROOT
It is superflous. rpm automatically cleans RPM_BUILD_ROOT


* Please remove "--prefix=%{_prefix} --libdir=%{_libdir}" from the call to
%configure. These options are automatically added by %configure.

* Please increment  Release each time you change something in your spec and
reflect this to the %changelog.

Besides this, based on visual inspection only (I haven't tried to build), the
spec looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]