[Bug 977208] Review Request: Phalcon - A web framework implemented as a C extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=977208



--- Comment #41 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
(In reply to Renich Bon Ciric from comment #40)

> @Remi
> Anyway, what's next? Will you package it or should we co-maintain?

This is your review ;)

I just want to raise your attention that the non-free issue is now fixed
upstream (will be in 1.3.3, all my PR have be merged) so you can start updating
your spec and go with the review.

Of course, you can take some changes from my spec file (strip.sh, genbuild in
%prep, ZTS build...) I only run test from ext/texts, but the PHPUnit suite
should also be run, IIUC this should be the only one in 2.x)

Notice: instead of patching the phpunit configuration file, it will be simpler
to use the --exclude-group option (and add the @group annotation in the unit
tests, change which can be submitted upstream)

If you want I can also be co-maintainer. If you use this framework, you are
probably a better owner than me (I mostly work on it to fix the PHP 5.6
compatibility). And I already own enough packages ;)

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]