Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dwarves - DWARF Tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-04-25 19:24 EST ------- Just a quick check (NOT official review), to fix some things which are obviously wrong: - Source 0 is not downloadable (pahole-0.tar.bz2). -->please provide a means to verify that the included source is identical to upstreaml in particular, Source0 should be the full URL to the source or a description on how can the source be downloaded (for instance from svn or cvs) - wrong BuildRoot; please see Packaging/Guidelines#BuildRoot in the wiki - several packages are included by default in the buildroot and need not to be included: gcc, make, binutils, glibc-devel; please see Packaging/Guidelines#Exceptions in the wiki - make does not honor SMP flags. If it doesn't build with it, please add a comment; please see Packaging/Guidelines#parallelmake in the wiki - make does not honor RPM_OPT_FLAGS; I suggest taking a look at http://fedoraproject.org/wiki/PackagingDrafts/cmake - cosmetical change: would be nice if the rm -f line in %install and %clean would use the same -r or -R flag - rpmlint on the generated binary gives lots of warnings/errors: rpmlint of dwarves: W: dwarves devel-file-in-non-devel-package /usr/lib64/ctracer/ctracer_jprobe.c W: dwarves spurious-executable-perm /usr/lib64/ctracer/ctracer_jprobe.c E: dwarves script-without-shebang /usr/lib64/ctracer/Makefile W: dwarves devel-file-in-non-devel-package /usr/lib64/ctracer/ctracer_relay.h W: dwarves spurious-executable-perm /usr/lib64/ctracer/ctracer_relay.h W: dwarves devel-file-in-non-devel-package /usr/lib64/ctracer/ctracer_relay.c W: dwarves spurious-executable-perm /usr/lib64/ctracer/ctracer_relay.c W: dwarves non-standard-group Base W: dwarves no-version-in-last-changelog E: dwarves only-non-binary-in-usr-lib rpmlint of dwarves-debuginfo: W: dwarves-debuginfo no-version-in-last-changelog rpmlint of libdwarves-devel: W: libdwarves-devel no-documentation W: libdwarves-devel no-dependency-on libdwarves W: libdwarves-devel non-standard-group Development W: libdwarves-devel no-version-in-last-changelog rpmlint of libdwarves1: W: libdwarves1 no-documentation E: libdwarves1 library-without-ldconfig-postin /usr/lib64/libdwarves.so.1.0.0 E: libdwarves1 library-without-ldconfig-postun /usr/lib64/libdwarves.so.1.0.0 W: libdwarves1 non-standard-group Libraries W: libdwarves1 no-version-in-last-changelog - wrong permissions of files: all files --including .c, .h, .py? in package dwarves-0-18.x86_64.rpm have exec bit set (755 instead of 644) - same goes for the files in the debug package -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review