[Bug 1130103] Review Request: blink - Real-time communications client using SIP protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1130103



--- Comment #4 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> ---
Hi Felix.

(In reply to Felix Schwarz from comment #3)
> just a few comments by looking at the spec *very* briefly:
> The dependencies are very likely wrong. python-ejson, python-eventlib,
> python-django, python-redis, python-celery, python-gnutls, python-dns,
> python-xcaplib and python-twisted-names are not listed in "install.linux"
> from the source package. I'd be surprised if a qt application needs Django.

May be you are right. I'm not so familiar with python stuff, so any help
appreciated.

Meantime most runtime dependencies was born in tries run it. For example,
without python-gnutls it failed to start like:
1) $ blink
Traceback (most recent call last):
  File "/usr/bin/blink", line 29, in <module>
    from blink import Blink
  File "/usr/lib64/python2.7/site-packages/blink/__init__.py", line 28, in
<module>
    from gnutls.crypto import X509Certificate, X509PrivateKey
ImportError: No module named gnutls.crypto

2) without python-dns (revert back python-gnutls):
$ blink
using set_wakeup_fd
Traceback (most recent call last):
  File "/usr/bin/blink", line 29, in <module>
    from blink import Blink
  File "/usr/lib64/python2.7/site-packages/blink/__init__.py", line 32, in
<module>
    from sipsimple.account import Account, AccountManager, BonjourAccount
  File "/usr/lib64/python2.7/site-packages/sipsimple/account/__init__.py", line
26, in <module>
    from sipsimple.account.publication import PresencePublisher,
DialogPublisher
  File "/usr/lib64/python2.7/site-packages/sipsimple/account/publication.py",
line 23, in <module>
    from sipsimple.lookup import DNSLookup, DNSLookupError
  File "/usr/lib64/python2.7/site-packages/sipsimple/lookup.py", line 19, in
<module>
    import dns
ImportError: No module named dns
3) Without python-eventlib:
$ blink
Traceback (most recent call last):
  File "/usr/bin/blink", line 29, in <module>
    from blink import Blink
  File "/usr/lib64/python2.7/site-packages/blink/__init__.py", line 27, in
<module>
    from eventlib import api
ImportError: No module named eventlib
4) $ sudo rpm -e python-xcaplib --nodeps
[pasha@hubbitus ~]$ blink
using set_wakeup_fd
Traceback (most recent call last):
  File "/usr/bin/blink", line 29, in <module>
    from blink import Blink
  File "/usr/lib64/python2.7/site-packages/blink/__init__.py", line 32, in
<module>
    from sipsimple.account import Account, AccountManager, BonjourAccount
  File "/usr/lib64/python2.7/site-packages/sipsimple/account/__init__.py", line
29, in <module>
    from sipsimple.account.xcap import XCAPManager
  File "/usr/lib64/python2.7/site-packages/sipsimple/account/xcap/__init__.py",
line 29, in <module>
    from xcaplib.green import XCAPClient
ImportError: No module named xcaplib.green
5) $ sudo rpm -e python-twisted-names --nodeps
[pasha@hubbitus ~]$ blink
using set_wakeup_fd
Traceback (most recent call last):
  File "/usr/bin/blink", line 29, in <module>
    from blink import Blink
  File "/usr/lib64/python2.7/site-packages/blink/__init__.py", line 34, in
<module>
    from sipsimple.application import SIPApplication
  File "/usr/lib64/python2.7/site-packages/sipsimple/application.py", line 33,
in <module>
    from sipsimple.session import SessionManager
  File "/usr/lib64/python2.7/site-packages/sipsimple/session.py", line 39, in
<module>
    from sipsimple.streams import MediaStreamRegistry, InvalidStreamError,
UnknownStreamError
  File "/usr/lib64/python2.7/site-packages/sipsimple/streams/__init__.py", line
116, in <module>
    from sipsimple.streams import rtp, msrp
  File "/usr/lib64/python2.7/site-packages/sipsimple/streams/msrp.py", line 38,
in <module>
    from msrplib.connect import DirectConnector, DirectAcceptor,
RelayConnection, MSRPRelaySettings
  File "/usr/lib/python2.7/site-packages/msrplib/connect.py", line 47, in
<module>
    from twisted.names.srvconnect import SRVConnector
ImportError: No module named names.srvconnect


python-ejson, python-celery, python-redis, python-django really seems not used
in current version. At least for start. Removed.

And even more I forgot python-msrplib, added.
$ blink
using set_wakeup_fd
Traceback (most recent call last):
  File "/usr/bin/blink", line 29, in <module>
    from blink import Blink
  File "/usr/lib64/python2.7/site-packages/blink/__init__.py", line 34, in
<module>
    from sipsimple.application import SIPApplication
  File "/usr/lib64/python2.7/site-packages/sipsimple/application.py", line 33,
in <module>
    from sipsimple.session import SessionManager
  File "/usr/lib64/python2.7/site-packages/sipsimple/session.py", line 39, in
<module>
    from sipsimple.streams import MediaStreamRegistry, InvalidStreamError,
UnknownStreamError
  File "/usr/lib64/python2.7/site-packages/sipsimple/streams/__init__.py", line
116, in <module>
    from sipsimple.streams import rtp, msrp
  File "/usr/lib64/python2.7/site-packages/sipsimple/streams/msrp.py", line 38,
in <module>
    from msrplib.connect import DirectConnector, DirectAcceptor,
RelayConnection, MSRPRelaySettings
ImportError: No module named msrplib.connect

> Also qt is only build-required but I guess it's important to have it at
> runtime as well. ;-)
Fixed.

> I'd recommend using Fedora's package names if possible (though that's only a
> personal preference, probably not required by any official policy).
I have no personal preferences, so it changed also.


Changes:
https://github.com/Hubbitus/Fedora-packaging/commit/5c6d4ff83f7c952e22d5025c44858f250317fe89
Spec:
https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/5c6d4ff83f7c952e22d5025c44858f250317fe89/SPECS/blink.spec
Srpm: http://hubbitus.info/rpm/Fedora20/blink/blink-0.9.1-2.fc20.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7545256

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]