[Bug 1139009] Review Request: perl-LV - LV ♥ lvalue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1139009



--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
Could we get a more descriptive summary?

You could substitute PERL_INSTALL_ROOT with the standard DESTDIR.

You could drop line 41; it's unnecessary nowadays.

You're missing some BRs, namely:
 - Carp, lib/LV/Backend/Magic.pm:10, via 04magic.t
 - Exporter, lib/LV.pm:16, via 01basic.t
 - strict, used by everything
 - Variable::Magic, lib/LV/Backend/Magic.pm:11, via 04magic.t -> lib/LV.pm:46
 - warnings, used by everything

Both 03sentinel.t and 04magic.t will skip their plans if the backend modules
cannot be loaded, therefore Carp, Sentinel and Variable::Magic are optional. 
However, it'd be a good idea to run those tests anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]