Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: taxipilot - Game where you pilot a taxi in space https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237813 ------- Additional Comments From Jochen@xxxxxxxxxxxxxxx 2007-04-25 17:09 EST ------- Good: + Naming seems good. + License seems ok. + Local Build works fine. + Rpmlint is quite on source rpm. + Local install and uninstall works fine. + Could start game. + Mock build works fine. Bad: - Rpmlint complaints binary package: rpmlint taxipilot-0.9.1-1.x86_64.rpm W: taxipilot dangling-symlink /usr/share/doc/HTML/en/taxipilot/common /usr/share/doc/HTML/en/common W: taxipilot symlink-should-be-relative /usr/share/doc/HTML/en/taxipilot/common /usr/share/doc/HTML/en/common E: taxipilot zero-length /usr/share/apps/taxipilot/game_data/game_data_tag - Package doesn't conatins varbatin copy ot the license text. Upstream tar bar contains file COPYING which should be in the %doc stanza. - Rpmlint complaints the installed package: rpmlint taxipilot W: taxipilot dangling-symlink /usr/share/doc/HTML/en/taxipilot/common /usr/share/doc/HTML/en/common W: taxipilot symlink-should-be-relative /usr/share/doc/HTML/en/taxipilot/common /usr/share/doc/HTML/en/common E: taxipilot zero-length /usr/share/apps/taxipilot/game_data/game_data_tag W: taxipilot undefined-non-weak-symbol /usr/lib64/libEXT_wavpo.so.0.0.0 _ZN4Arts7Factory7startupEv W: taxipilot undefined-non-weak-symbol /usr/lib64/libEXT_wavpo.so.0.0.0 _ZN4Arts7Factory8shutdownEv W: taxipilot undefined-non-weak-symbol /usr/lib64/libEXT_wavpo.so.0.0.0 _ZTIN4Arts7FactoryE W: taxipilot undefined-non-weak-symbol /usr/lib64/libEXT_wavpo.so.0.0.0 _ZTv0_n24_N4Arts11Object_skel6notifyERKNS_12NotificationE W: taxipilot undefined-non-weak-symbol /usr/lib64/libEXT_wavpo.so.0.0.0 _ZTv0_n40_N4Arts11Object_skel5_skelEv W: taxipilot undefined-non-weak-symbol /usr/lib64/libEXT_wavpo.so.0.0.0 _ZN4Arts11Object_base5_stubEv === CUT === for the undefined-non-week-symbol issue, please notify the upstream to fix it. There are a lot of such messages from rpmlint. - Source0 Tag in SPEC file doesn't show to the upstram tar ball. A HTTP-Code 404 occured. - Could not build package for target i686 on the x86_64 system: checking for perl... /usr/bin/perl checking for Qt... configure: error: Qt (>= Qt 3.1 (20021021)) (library qt-mt) not found. Please check your installation! For more details about this problem, look at the end of config.log. Make sure that you have compiled Qt with thread support! Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.75137 (%build) BTW: Becouse I'm on vacation in the next way, I don't assign the review to me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review