[Bug 1040517] Review Request: julia - High-level, high-performance dynamic language for technical computing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1040517



--- Comment #56 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Have you pointed the fedora-review tool at this ticket yet? -> "fedora-review
-b 1040517"

After a brief look at the spec file, I think there are a couple of places that
would benefit from trying to perform a self-review of your own spec file. It
will help you understanding the package more deeply.


> %files
> %{_libdir}/julia/*.so

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

> %{_datadir}/julia/base/

Same here.


> %config(noreplace) %{_sysconfdir}/julia/juliarc.jl

Same here.


> %post devel -p /sbin/ldconfig
> %postun devel -p /sbin/ldconfig

Very doubtful. Typically, ldconfig is only run for _runtime_ library packages,
whereas -devel packages only contain symlinks needed at build-time, and that's
not ldconfig's area.

https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages


> %files doc
> %docdir %{_datadir}/julia/doc
> %{_datadir}/julia/doc

Unowned directories here, too.  Using %docdir here is not convenient, since you
add the contents of a single directory only.

  %dir %{_datadir}/julia/doc
  %doc %{_datadir}/julia/doc/*


> %files devel
> %{_bindir}/julia-debug
> %{_libdir}/libjulia.so

Please double-check whether this is a runtime library that belongs into the
base %name package instead:
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages


> %package doc
> Summary:        Julia documentation and code examples
> Group:          Development/Languages

"Group: Documentation" if you really want to set the Group tag.
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag


> Requires:       fftw >= 3.3.2
> Requires:       gmp
> Requires:       lapack
> Requires:       mpfr
> Requires:       openblas
> Requires:       openlibm >= 0.4
> Requires:       openspecfun >= 0.4

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]