https://bugzilla.redhat.com/show_bug.cgi?id=1136972 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dan@xxxxxxxx --- Comment #5 from Dan Horák <dan@xxxxxxxx> --- some notes for the start: - the source archive is weird, it contains another copy of the paflib tree, please use github provided archive (https://github.com/paflib/paflib/archive/0.1-2.tar.gz) - would be great if upstream could switch to versioning without the dash, eg. 0.1-2.tar.gz will be 0.1.2.tar.gz - use %{configure} macro, no need to manually step into the build directory, rpmbuild does that on its own - drop outdated %defattr() definitions, rpmbuild adds the defaults itself - simplify %install section to just "make install ..." - as Ralf said, look into another package how the main/devel/static split should look like, but are the static libs necessary, Fedora discourages packaging them (https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Packaging_Static_Libraries) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review