[Bug 1138292] Review Request: perl-Dist-Zilla-Plugin-ReadmeFromPod - Automatically convert POD to a README for Dist::Zilla

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1138292

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Spec file changes:

$ diff -u perl-Dist-Zilla-Plugin-ReadmeFromPod.spec{.old,}---
perl-Dist-Zilla-Plugin-ReadmeFromPod.spec.old       2014-09-04
14:39:15.000000000 +0200
+++ perl-Dist-Zilla-Plugin-ReadmeFromPod.spec   2014-09-04 15:45:34.000000000
+0200
@@ -8,18 +8,18 @@
 Source0:       
http://www.cpan.org/authors/id/F/FA/FAYLAND/Dist-Zilla-Plugin-ReadmeFromPod-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl
-BuildRequires:  perl(Dist::Zilla::File::InMemory)
 BuildRequires:  perl(Dist::Zilla::Role::InstallTool) >= 5
 BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
 BuildRequires:  perl(File::Spec)
+BuildRequires:  perl(IO::Handle)
 BuildRequires:  perl(IPC::Open3)
 BuildRequires:  perl(Moose)
 BuildRequires:  perl(Moose::Autobox)
-BuildRequires:  perl(Pod::Text)
 BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(warnings)
 Requires:       perl(Dist::Zilla::Role::InstallTool) >= 5
+Requires:       perl(Pod::Simple) >= 3.23
 Requires:       perl(Pod::Text)
 Requires:       perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo
$version))


> FIX: Build-require `perl(IO::Handle)' (t/00-compile.t:22).
+BuildRequires:  perl(IO::Handle)
Ok.

> FIX: Do not build-require `perl(Dist::Zilla::File::InMemory)'. It's not used
> at tests.
-BuildRequires:  perl(Dist::Zilla::File::InMemory)
Ok.

> FIX: Do not build-require `perl(Pod::Text)'. It's not used at tests.
-BuildRequires:  perl(Pod::Text)
Ok.

$ rpmlint perl-Dist-Zilla-Plugin-ReadmeFromPod.spec
../SRPMS/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.src.rpm
../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

> FIX: Require `perl(Pod::Simple) >= 3.23' (lib/Dist/Zilla/Plugin/ReadmeFromPod.pm:34). See <https://rt.cpan.org/Public/Bug/Display.html?id=90032> for the explanation.
$ rpm -q --requires -p
../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm |
sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(Dist::Zilla::Role::InstallTool) >= 5
      1 perl(Moose)
      1 perl(Moose::Autobox)
      1 perl(Pod::Simple) >= 3.23
      1 perl(Pod::Text)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Binary requires are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F22
(http://koji.fedoraproject.org/koji/taskinfo?taskID=7523178). Ok.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]