[Bug 1138292] Review Request: perl-Dist-Zilla-Plugin-ReadmeFromPod - Automatically convert POD to a README for Dist::Zilla

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1138292



--- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> ---
URL and Source0 are usable. Ok.
Source archive is original (SHA-256:
3b255ec052ef896e525217d0025fab0767b53ef7a940f89d683e870f51331f8a). Ok
License verified from README, LICENSE, and
lib/Dist/Zilla/Plugin/ReadmeFromPod.pm. Ok.
Summary verified from lib/Dist/Zilla/Plugin/ReadmeFromPod.pm. Ok.
Description verified from lib/Dist/Zilla/Plugin/ReadmeFromPod.pm. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Build-require `perl(IO::Handle)' (t/00-compile.t:22).

FIX: Do not build-require `perl(Dist::Zilla::File::InMemory)'. It's not used at
tests.
FIX: Do not build-require `perl(Pod::Text)'. It's not used at tests.

All tests pass. Ok.

$ rpmlint perl-Dist-Zilla-Plugin-ReadmeFromPod.spec
../SRPMS/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.src.rpm
../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p
../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Sep  4 15:20
/usr/share/doc/perl-Dist-Zilla-Plugin-ReadmeFromPod
-rw-r--r--    1 root    root                     2474 Nov  4  2013
/usr/share/doc/perl-Dist-Zilla-Plugin-ReadmeFromPod/Changes
-rw-r--r--    1 root    root                    18437 Nov  4  2013
/usr/share/doc/perl-Dist-Zilla-Plugin-ReadmeFromPod/LICENSE
-rw-r--r--    1 root    root                      721 Nov  4  2013
/usr/share/doc/perl-Dist-Zilla-Plugin-ReadmeFromPod/README
-rw-r--r--    1 root    root                     2180 Sep  4 15:20
/usr/share/man/man3/Dist::Zilla::Plugin::ReadmeFromPod.3pm.gz
drwxr-xr-x    2 root    root                        0 Sep  4 15:20
/usr/share/perl5/vendor_perl/Dist
drwxr-xr-x    2 root    root                        0 Sep  4 15:20
/usr/share/perl5/vendor_perl/Dist/Zilla
drwxr-xr-x    2 root    root                        0 Sep  4 15:20
/usr/share/perl5/vendor_perl/Dist/Zilla/Plugin
-rw-r--r--    1 root    root                     2069 Nov  4  2013
/usr/share/perl5/vendor_perl/Dist/Zilla/Plugin/ReadmeFromPod.pm
File layout and permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm |
sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(Dist::Zilla::Role::InstallTool) >= 5
      1 perl(Moose)
      1 perl(Moose::Autobox)
      1 perl(Pod::Text)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1

FIX: Require `perl(Pod::Simple) >= 3.23'
(lib/Dist/Zilla/Plugin/ReadmeFromPod.pm:34). See
<https://rt.cpan.org/Public/Bug/Display.html?id=90032> for the explanation.

$ rpm -q --provides -p
../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm |
sort -f | uniq -c
      1 perl(Dist::Zilla::Plugin::ReadmeFromPod) = 0.21
      1 perl-Dist-Zilla-Plugin-ReadmeFromPod = 0.21-1.fc22
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F22
(http://koji.fedoraproject.org/koji/taskinfo?taskID=7522721). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' items, and provide a new spec file.
Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]