https://bugzilla.redhat.com/show_bug.cgi?id=1133950 --- Comment #2 from Honza Horak <hhorak@xxxxxxxxxx> --- Some notes before doing a proper formal review. Matej, please, look at them and the issues already reported by Christopher and I'll do a proper formal review after these issues are fixed. * Name of the package should be the same as upstream project name if possible, but I'm not sure if tar ball name actually is that name, I'd rather use launchpad's project name mariadb-native-client [1] or even consult the name with upstream. * There should be -devel sub-package created that would include mariadb_config script, header files and unversioned library (link) [2]. * Changelog should contain version-release after packager contact [3]. * Removing $RPM_BUILD_ROOT is not necessary in %install nor %clean have be there any more [4]. * Build should use default compiler flags [5]. * Static libraries should be removed or disabled in cmake, if it is possible, but definitely not packaged [6]. * The tar ball bundles zlib, just be sure it is not compiled and used, and system zlib is used instead. * The doc in xml needs to be generated into html doc first (which needs xmlto package as BuildRequires). The generated docs could be included in the -devel or in a separeted subpackage. * The path to installed libraries is /usr/lib instead of /usr/lib64 on x86_64, some cmake option will have to be used maybe. [1] https://launchpad.net/mariadb-native-client [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages [3] https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs [4] https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean [5] https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags [6] https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review